Skip to content

feat: add globalproxysettings #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliverbaehler merged 1 commit into from
Jan 10, 2025
Merged

feat: add globalproxysettings #550

oliverbaehler merged 1 commit into from
Jan 10, 2025

Conversation

@oliverbaehler
Copy link
Collaborator

@oliverbaehler oliverbaehler commented Oct 20, 2024 •
edited
Loading

This PR proposes a new CRD for the capsule-proxy GlobalProxySettings. Its meant for use-cases, where we want to bind clusterScoped Listing permissions to subjects (eg. listing clusters). An example:

apiVersion: capsule.clastix.io/v1beta1
kind: GlobalProxySettings
metadata:
  name: global-proxy-settings
spec:
  rules:
  - subjects:
    - kind: User
      name: alice
    clusterResources:
    - apiGroups:
      - "*"
      resources:
      - "*"
      operations:
      - List
      selector:
        matchLabels:
          app.kubernetes.io/type: dev
  - subjects:
     - kind: User
       name: alice
    clusterResources:
     - apiGroups:
       - "*"
       resources:
       - "*"
       operations:
       - List
       selector:
         matchLabels:
           app.kubernetes.io/type: meowie

It converts all modules to GKs to GVKs. This is a preparation to make clusterResources properties compatible with tenant selected attributes (for cluster-scoped resources)

It also adds a first e2e usinbg ginkgo, im going to add more tests in seperate PRs. Creates the fundament for #257

@oliverbaehler oliverbaehler force-pushed the feat/global-crd branch 2 times, most recently from 94325c5 to da2469d Compare October 20, 2024 08:21
@oliverbaehler oliverbaehler changed the title WIP: feat: add globalproxysettings feat: add globalproxysettings Oct 20, 2024
prometherion
prometherion approved these changes Dec 1, 2024
View reviewed changes
Copy link
Member

@prometherion prometherion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please, let's fix the linter, happy to have at least some e2e back in place 🫠

@prometherion
Copy link
Member

prometherion commented Dec 4, 2024

Sorry Oliver, again conflicts 🫠 that's my fault!

@oliverbaehler oliverbaehler force-pushed the feat/global-crd branch 2 times, most recently from 82f10c1 to 6eded86 Compare January 10, 2025 01:50
@oliverbaehler
feat: add globalproxysettings
a9108f3 
Signed-off-by: Oliver Bähler <[email protected]>
@oliverbaehler oliverbaehler merged commit f2c393e into projectcapsule:main Jan 10, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prometherion prometherion prometherion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oliverbaehler @prometherion